JPDA Evaluator: Value, Description and Children should not be fetched on the EDT #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the EDT While running NetBeans with assertions enabled, while tryping to open the detail/value dialog for the "String value", an AssertionError was observed. java.lang.AssertionError: Debugger lock taken in AWT Event Queue! at org.netbeans.modules.debugger.jpda.JPDADebuggerImpl$DebuggerReentrantReadWriteLock$DebuggerReadLock.lock(JPDADebuggerImpl.java:2710) at org.netbeans.modules.debugger.jpda.models.JPDAThreadImpl$ThreadReentrantReadWriteLock$ThreadWriteLock.lock(JPDAThreadImpl.java:2581) at org.netbeans.modules.debugger.jpda.JPDADebuggerImpl.invokeMethod(JPDADebuggerImpl.java:1080) at org.netbeans.modules.debugger.jpda.JPDADebuggerImpl.invokeMethod(JPDADebuggerImpl.java:1022) at org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:500) at org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:464) at org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:428) at org.netbeans.modules.debugger.jpda.ui.models.VariablesTableModel.getValueAt(VariablesTableModel.java:108) at org.netbeans.spi.viewmodel.Models$DelegatingTableModel.getValueAt(Models.java:2249) at org.netbeans.modules.debugger.jpda.ui.models.NumericDisplayFilter.getValueAt(NumericDisplayFilter.java:112) at org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439) at org.netbeans.modules.debugger.jpda.ui.models.VariablesTreeModelFilter.getValueAt(VariablesTreeModelFilter.java:530) at org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439) at org.netbeans.modules.debugger.jpda.ui.models.EvaluatorTableModelFilter.getValueAt(EvaluatorTableModelFilter.java:71) at org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439) at org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1441) at org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1441) at org.netbeans.spi.viewmodel.Models$CompoundModel.getValueAt(Models.java:4565) at org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.updateShortDescription(TreeModelNode.java:2094) at org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.getShortDescription(TreeModelNode.java:2076) at org.openide.explorer.propertysheet.CustomEditorAction.actionPerformed(CustomEditorAction.java:290) at org.openide.explorer.propertysheet.PropertyPanel$CustomEditorProxyAction.actionPerformed(PropertyPanel.java:1199) at org.openide.explorer.view.OutlineView$OutlineViewOutline.editCellAt(OutlineView.java:2115) at java.desktop/javax.swing.plaf.basic.BasicTableUI$Handler.adjustSelection(BasicTableUI.java:1147) at java.desktop/javax.swing.plaf.basic.BasicTableUI$Handler.mousePressed(BasicTableUI.java:1077) Indeed here the call comes from the EDT and directly tries to access the JPDA connection. The fix is inspired from JPDAAsynchronousModel and moves value fetching from the EDT to the JPDA thread.
matthiasblaesing
added
the
Java
|
I intent to merge this by next weekend if noone intervenes till then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running NetBeans with assertions enabled, while tryping to open the detail/value dialog for the "String value", an AssertionError was observed.
Indeed here the call comes from the EDT and directly tries to access the JPDA connection.
The fix is inspired from JPDAAsynchronousModel and moves value fetching from the EDT to the JPDA thread.